Fix Non-Immediate CSV Generation / Test for async download #35038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/reporting/csv-export-panel-action-no-job-create-for-immediate
…/reporting/csv-export-panel-action-no-job-create-for-immediate
…-for-immediate' into feature/reporting/csv-export-panel-action-fix-async
tsullivan
added
the
(Deprecated) Feature:Reporting
5 tasks
tsullivan
commented
Apr 12, 2019
| state: { | ||
| query: any; | ||
| sort: any[]; | ||
| columns: string[]; // TODO |
There was a problem hiding this comment.
columnsis not passed by the client currently.- Related: https://github.com/elastic/kibana/pull/34571/files#r275093173
This comment has been minimized.
This comment has been minimized.
…-for-immediate' into feature/reporting/csv-export-panel-action-fix-async
This comment has been minimized.
This comment has been minimized.
…-for-immediate' into feature/reporting/csv-export-panel-action-fix-async
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
|
The actual change starts here: 527df35 |
joelgriffith
force-pushed
the
feature/reporting/csv-export-panel-action
branch
from
3334140 to
4446428
Compare
|
retest |
💔 Build Failed |
|
retest |
…/reporting/csv-export-panel-action-fix-async
💔 Build Failed |
joelgriffith
merged commit 70c87c4
into
elastic:feature/reporting/csv-export-panel-action
tsullivan
deleted the
feature/reporting/csv-export-panel-action-fix-async
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #35011
This fixes "non-immediate" CSV generation.
The cause of the bug was that CSV generation depends on the payload body data of the request. That is fine when CSV is generated immediately because the actual request is available in context. For Non-Immediate, the payload body data needs to come from stored JobParams data: the meta-data that gets created during
createJob.ReqPayloadtypeJobParamPostPayloadwhich is a new field ofJobParams